[Java][Client] Add Deprecated annotation#6166
Conversation
hisener
changed the title
hisener
force-pushed
the
java-deprecated-annotation
branch
from
005fb9e to
c13283f
Compare
hisener
force-pushed
the
java-deprecated-annotation
branch
from
c13283f to
ad01039
Compare
|
@hisener thanks for adding support for |
|
Is there a reason this PR only added the |
|
https://docs.oracle.com/javase/tutorial/java/annotations/predefined.html |
|
I understand the difference between I'm confused as to what you mean by 'I haven't added the javadoc annotation' when the .mustache files changed in this PR all have the |
| {{/returnType}} | ||
| * @throws ApiException if fails to make API call | ||
| {{#isDeprecated}} | ||
| * @Deprecated |
There was a problem hiding this comment.
@hisener Isn't this a javadoc comment and not an annotation because the line starts with *?
| {{/returnType}} | ||
| * @throws ApiException if fails to make API call | ||
| {{#isDeprecated}} | ||
| * @Deprecated |
| * @return {{{returnType}}}{{/returnType}} | ||
| * @throws ApiException if fails to make API call | ||
| {{#isDeprecated}} | ||
| * @Deprecated |
|
Yes, I see now. You are right. |
|
Ah okay, thanks for clarifying! I've worked on some of the changes and just wanted to confirm, so I can probably just submit a PR soon. |
…2, okhttp-gson, resteasy libraries
…son, resteasy libraries (#6801)
3 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for breaking (non-backward compatible) changes.Description of the PR
Add
@Deprecatedannotations to generated Java clients.