[Java] Support custom ok-http authenticators#6261
Open
lwander wants to merge 1 commit intoswagger-api:masterfrom
Open
[Java] Support custom ok-http authenticators#6261lwander wants to merge 1 commit intoswagger-api:masterfrom
lwander wants to merge 1 commit intoswagger-api:masterfrom
Conversation
Users who want to supply custom authenticators can subclass `ApiClient` and override `getClientAuthenticators`.
Contributor
|
@lwander thanks for the PR. |
Contributor
|
Is subclassing the best way ? Why are the authentications unmodifiable in the first place ? |
Contributor
Author
|
My guess had been that modifying the authentications during runtime could lead to some strange behavior, especially if removing something like an OAuth authenticator while a token was still alive. But I don't know the underlying reason. Maybe we can restrict modification to only adding authenticators? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for breaking (non-backward compatible) changes.Description of the PR
Users who want to supply custom authenticators can subclass
ApiClientand overridegetClientAuthenticators.Waiting on #6256 to update petstore samples.