[Java][okhttp] Inheritance support #6636
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Nov 22, 2017
Merged
Conversation
Contributor
|
Similar work has been done before: #4729 |
cbornet
reviewed
Oct 10, 2017
| classByDiscriminatorValue.put("Cat".toUpperCase(), Cat.class); | ||
| classByDiscriminatorValue.put("Dog".toUpperCase(), Dog.class); | ||
| classByDiscriminatorValue.put("Animal".toUpperCase(), Animal.class); | ||
| return getClassByDiscriminator( |
cbornet
reviewed
Oct 10, 2017
| return o.toString().replace("\n", "\n "); | ||
| } | ||
|
|
||
Contributor
There was a problem hiding this comment.
Can we avoid this unwanted space ?
konopski
added a commit
to konopski/swagger-codegen
that referenced
this pull request
Oct 11, 2017
Contributor
Author
|
Sorry, this PR is getting messy with some old merges and changes from previous branches with retrofit. |
konopski
force-pushed
the
inheritance_support_java_client_okhttp_gson
branch
from
325e431 to
0655e94
Compare
Contributor
Author
|
I cleaned up the changes, including your remarks. |
Contributor
Travis build failure is more than likely not related to changes in this PR. It has some issues. |
Contributor
|
Travis test passed via https://travis-ci.org/swagger-api/swagger-codegen/builds/305624150 |
wing328
changed the title
eivinhb
added a commit
to eivinhb/swagger-codegen
that referenced
this pull request
May 2, 2018
…wagger-api#7836) After fixes for swagger-api#6636 the gson based clients would not compile if the swagger json did not have any model definitions. This can be the case if the API only uses simple datastructures for input and output. (int, String, List, Map etc.)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Inheritance support for okhttp with gson parser.
@cbornet Can you please take a look?