[JAVA] equals and hashCode for models with byte[] vars#6760
[JAVA] equals and hashCode for models with byte[] vars#6760bmordue wants to merge 4 commits intoswagger-api:masterfrom bmordue:array-equals-issue-3731
Conversation
the yaml currently includes invalid definitions that do not exist: ('#/definitions/xmlObject').
revert to known good yaml state.
|
I based my branch off #6758 to avoid a bunch of unwanted changes in the sample clients. |
|
I don't know how to cover the three cases of |
@bmordue Would |
|
I'll cherry-pick 533816c later as this PR contains too many changes not relevant to the fix. |
|
|
I'm closing this PR: #7341 is the same work in a cleaner PR. |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
For models with a byte array field, the generated
equalsandhashCodemethods are not correct. This change modifies the template to useArray.equalsandArrays.hashfor byte array variables.I think this goes at least some way to being a fix #3731
cc @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet