[TypeScript][Fetch] Change return type from any -> Response

[masaeedu]

Fixes #6772

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming langauge.

Description of the PR

Change the return type of API methods for which a response schema is not available to reflect that they return a Promise<Response> (instead of Promise<any>).

Technical committee reviewers

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx

[kenisteward]

@masaeedu have you checked this with a generated library to make sure Response was valid? I'm not sure if our tests cover it yet.

[masaeedu]

If you look at the method for which I've changed the return type, the final return value is templated as `return response{{#returnType}}.json(){{/returnType}};`. This means whenever the returnType mustache variable isn't present (which is the case in which we return any) the value returned is the raw Response object. On Oct 22, 2017 8:15 PM, "kenisteward" <notifications@github.com> wrote: @masaeedu <https://github.com/masaeedu> have you checked this with a generated library to make sure Response was valid? I'm not sure if our tests cover it yet. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6774 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgPyKj_9kE7XaIuu4UGWqYnXV0BuaHNks5su9qwgaJpZM4QBAqQ> .

[kenisteward]

yup i gathered that. I just wanted to make sure you tried this locally with an api you have and everything turned out fine.

Just a safety net until we get better integration tests online.

[kenisteward]

Also, to get ci to pass it seems as someone else's changes are needed. I had a pr as well and I just re-merged with master and that fixed it.

[masaeedu]

@kenisteward Rebased, thanks. The client library I'm generating compiles fine with the change when lib: [..., "dom"] is specified in tsconfig.json (which is already a requirement for getting the current isomorphic-fetch typings to work). This doesn't have any effect at runtime that I can think of, since all the types will get erased, so I'm not sure how else I can test it. Do the integration tests not run tsc on the petstore sample?

[kenisteward]

that's exactly what I wanted to know. As long as the one you generate for yourself works that's perfect :) I hope to in the future have a sample app that calls each of the endpoints.

[kenisteward]

Thanks for locally testing and the changes.

[masaeedu]

Hi @wing328. Any chance of getting this merged today? I have some other stuff that depends on this.