[Rust] Implement 'object' type conversion#6846
Merged
wing328 merged 3 commits intoswagger-api:masterfrom Nov 1, 2017
Merged
Conversation
This hopefully fixes the previous TODO; it at least fixes compilation errors for the specific swagger model I'm working with.
Letting the version float freely is scary, to say the least. This gives it a better chance at being future-proof. When the crate author had a recommended selector I picked that, otherwise I went semver compatible.
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains 2 fixes for the rust codegen.
First, the TODO for "Object" was replaced with the
serde_json::Valuetype.This at least makes it compile; I haven't ensured runtime functionality is correct, but it's certainly no worse than before.
Second, I've updated the provided
Cargo.tomlto include rough version selectors. They correspond to what it's picking now, but will future-proof it a bit more against external crate changes.cc @frol @farcaller