Skip to content

Minor fix to body parameter in required parameter list #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Nov 5, 2017
Merged

Minor fix to body parameter in required parameter list #6885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9fd2f3
minor fix to required parameter list
wing328 Nov 4, 2017
edcf7a5
better if then else block
wing328 Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,17 +2227,7 @@ public CodegenOperation fromOperation(String path,
}
}

// set isPrimitiveType and baseType for allParams
/*if (languageSpecificPrimitives.contains(p.baseType)) {
p.isPrimitiveType = true;
p.baseType = getSwaggerType(p);
}*/


allParams.add(p);
if (p.required || p.isBodyParam) {
requiredParams.add(p.copy());
}
// Issue #2561 (neilotoole) : Moved setting of is<Type>Param flags
// from here to fromParameter().
if (param instanceof QueryParameter) {
Expand All @@ -2257,7 +2247,10 @@ public CodegenOperation fromOperation(String path,
} else if (param instanceof FormParameter) {
formParams.add(p.copy());
}
if (!p.required) {

if (p.required) { //required parameters
requiredParams.add(p.copy());
} else { // optional parameters
op.hasOptionalParams = true;
}
}
Expand Down