[PHP][Symfony] Removed wrong import of StrictJsonDeserializationVisitor#6948
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Nov 27, 2017
Merged
Conversation
Contributor
|
@Gingonic thanks for the PR. Please run |
Contributor
Author
|
@wing328 Sorry for that. Added the sample tests passing. |
Contributor
Author
|
@wing328 I think this is ready. What are the next steps, will someone be assigned to this for review and merging? |
Contributor
|
@Gingonic thanks for the PR, which has been merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
For the PHP Symfony generation this import
is wrong as the class is sitting in the same package as the JMSSerializer class.
This results in exception when the serializer is used
@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @naelrashdeen