[python] fix tests, tornado ssl fix#6968
Conversation
Does this mean that flake8 failure will be also ignored? Should we use |
|
Travis sees an exit code from a script but it's exit code from last command. So we have situation where python test failed but flake8 "covers" it and returns 0. Now I exit immediately if python tests failed. flake8 is a last command so its code will be interpreted correctly. If flake return non-zero code, Travis will notice it. I consider using |
Finally I had to drop compatibility with older Python. It's more complicated and I'll fix it in next PR. |
|
Looks good to me! |
|
cc @toumorokoshi as well |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixes related to:
@skipand also force endpoint name tolocalhost. IMO it'll remind developers about starting a local instance. Test endpoint returns invalid data #6907Please take a look: @wing328 @taxpon @frol @mbohlool @cbornet @kenjones-cisco