Skip to content

[PHP][Symfony] Further enhancements#7001

Merged
wing328 merged 2 commits intoswagger-api:masterfrom
Penneo:php-symfony-further-enhancements
Nov 27, 2017
Merged

[PHP][Symfony] Further enhancements#7001
wing328 merged 2 commits intoswagger-api:masterfrom
Penneo:php-symfony-further-enhancements

Conversation

@naelrashdeen
Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming langauge.

Description of the PR

The current PHP Symfony needs some further changes, which are described below:

  • Headers are not being fetched properly in the request
  • Objects should be mapped to arrays instead, in the model classes to be compatible with Symfony type validation
  • Deserialising arrays as collection formats are not working properly
  • Correct data type is not set in the comments for the Api interfaces

Closes #6999

@naelrashdeen naelrashdeen force-pushed the php-symfony-further-enhancements branch from adfaaef to dcfef3a Compare November 20, 2017 10:30
@naelrashdeen naelrashdeen changed the title Php symfony further enhancements [PHP][Symfony] Further enhancements Nov 20, 2017
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Nov 21, 2017

@wing328 wing328 added this to the v2.3.0 milestone Nov 27, 2017
@wing328 wing328 merged commit 5d59dd1 into swagger-api:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants