[JAX-RS] Initialize optional properties as null#7066
Merged
wing328 merged 4 commits intoswagger-api:masterfrom Dec 4, 2017
Merged
[JAX-RS] Initialize optional properties as null#7066wing328 merged 4 commits intoswagger-api:masterfrom
wing328 merged 4 commits intoswagger-api:masterfrom
Conversation
Contributor
Author
|
@wing328 As discussed, I have created a fresh PR to remove initialization for optional list. |
wing328
reviewed
Nov 28, 2017
bin/jaxrs-cxf-petstore-server.sh
Outdated
| fi | ||
|
|
||
| executable="./modules/swagger-codegen-cli/target/swagger-codegen-cli.jar" | ||
| executable="../modules/swagger-codegen-cli/target/swagger-codegen-cli.jar" |
Contributor
There was a problem hiding this comment.
Like other scripts, please run from the root directory of the project.
In other words, please keep "./modules/..."
wing328
reviewed
Nov 28, 2017
| {{/description}} | ||
| private {{{datatypeWithEnum}}} {{name}} = {{{defaultValue}}};{{/vars}} | ||
| {{#isContainer}}private {{{datatypeWithEnum}}} {{name}}{{#required}} = {{{defaultValue}}}{{/required}}{{^required}} = null{{/required}};{{/isContainer}} | ||
| {{^isContainer}}private {{{datatypeWithEnum}}} {{name}} = {{{defaultValue}}};{{/isContainer}} |
Contributor
There was a problem hiding this comment.
Please do the following instead to avoid lines with empty spaces.
{{^isContainer}}
private {{{datatypeWithEnum}}} {{name}} = {{{defaultValue}}};
{{/isContainer}}
Contributor
Author
|
@wing328 Can you please review my PR and tell me if the PR is fine for merge now. |
Contributor
|
@Sridhar-1987 thanks for the PR, which looks good to me. |
wing328
changed the title
|
It seems that the exact same issue is present for jax-rs-cdi generator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Fix added for missing JavaJaxrs/CXF for supporting Optional as null
#5363