Re-organize the reserved words for Swift4#7296
Merged
wing328 merged 1 commit intoswagger-api:2.4.0from Jan 7, 2018
Merged
Conversation
Contributor
Author
jgavris
approved these changes
Jan 2, 2018
Contributor
|
@ehyche when you've time, can you please update the following test as |
Contributor
|
@ehyche no worry I've fixed the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
There was a previous issue (#6919) and subsequent PR (#6952) to add "throw" to the list of reserved words for Swift 4.
I decided it would be helpful to group the Swift4 reserved words into groups that we can check against future revisions of swift. For each group, I provided a reference link so that we can check in the future if new reserved words have been added. I verified that all of the current reserved words are included somewhere in the new groupings. The groups are: