Use supportsES6 flag in ts compilation for language typescript-angular#7408
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Jan 22, 2018
ecsec:angular-es5
Merged
Use supportsES6 flag in ts compilation for language typescript-angular#7408wing328 merged 1 commit intoswagger-api:masterfrom ecsec:angular-es5
wing328 merged 1 commit intoswagger-api:masterfrom
ecsec:angular-es5
Conversation
Contributor
TiFu
approved these changes
Jan 21, 2018
Contributor
There was a problem hiding this comment.
Looks good to me.
The default remains supportsES6 = false so this is a non-breaking change.
For reference: AbstractTypeScriptClientCodegen
jimschubert
added a commit
to jimschubert/swagger-codegen
that referenced
this pull request
Jan 22, 2018
* master: (133 commits) add a link to ebook (polish version) Add R namespace file (swagger-api#7467) Add Spring Petstore samples (async, java8-localdatetime) to CircleCI (swagger-api#7468) Revised core team members Ada code generator corrected: "=>" instead of "->". Fixes swagger-api#7450 (swagger-api#7456) Fixes issue swagger-api#7177 (SpringCodeGen dateLibrary "java8-localdatetime" option is ignored). (swagger-api#7178) Issue-7438 Fix that prevents generating interfaces when interfaceOnly is false. (swagger-api#7439) swagger-api#7093 - Add maven wrapper (swagger-api#7356) [csharp] Support arrays of arrays for properties and models (swagger-api#7400) [csharp] Fix ToJson to work with composition and polymorphism (swagger-api#7399) [csharp] Reference this.Configuration in client api template (swagger-api#7394) [JAX-RS][Spec] Removes throws Exception. (swagger-api#7437) Use supportsES6 flag in ts compilation for language typescript-angular (swagger-api#7408) Fix 7457: [Ada] wrong order for generated structures in *-models.ads (swagger-api#7462) Fix 7459: [Ada] wrong JSON in POST operations (swagger-api#7460) [erlang-client] Erlang request utils (swagger-api#7257) reenable pushing snapshot to maven repo Create CODE_OF_CONDUCT.md comment out update to docker image deleted unnecessary notes (swagger-api#7454) ...
viclovsky
pushed a commit
to viclovsky/swagger-codegen
that referenced
this pull request
Jan 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using the client generated for language typescript-angular in a NativeScript project which can't deal with es6 modules. This fix uses the supportsES6 option to set appropriate values in the TypeScript compiler options.