Kotlin generator migration/cleanup#7739
Merged
HugoMario merged 18 commits intoswagger-api:3.0.0from Apr 11, 2018
Merged
Conversation
Contributor
|
The cleanup tasks are now different (this explains the conflicts):
|
Author
|
Additional cleanup tasks now complete |
jimschubert
reviewed
Mar 7, 2018
| # if you've executed sbt assembly previously it will use that instead. | ||
| export JAVA_OPTS="${JAVA_OPTS} -XX:MaxPermSize=256M -Xmx1024M -DloggerPath=conf/log4j.properties" | ||
| ags="generate -t modules/swagger-codegen/src/main/resources/kotlin-client -i modules/swagger-codegen/src/test/resources/2_0/petstore.yaml -l kotlin --artifact-id kotlin-petstore-client -o samples/client/petstore/kotlin $@" | ||
| ags="generate -i modules/swagger-codegen/src/test/resources/2_0/petstore.yaml -l kotlin-client --artifact-id kotlin-petstore-client -o samples/client/petstore/kotlin $@" |
Contributor
There was a problem hiding this comment.
I think it's weird that "language" is "kotlin-client".
Contributor
|
@jimschubert having For the moment this pull request is "On hold" until kotlin is added to the |
Author
|
This is should be good to merge now that swagger-api/swagger-codegen-generators#26 has gone in |
Contributor
|
thanks @tcslater !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up kotlin related files for migration to https://github.com/swagger-api/swagger-codegen-generators
Relies on related PR for swagger-codegen-generators swagger-api/swagger-codegen-generators#26