Add x-root-ancestor vendor extension boolean property to use inheritance w/o discriminator (see #6127). #7910
Open
SergeyLyakhov wants to merge 2 commits intoswagger-api:masterfrom
Open
Conversation
|
Any chance of getting this merged? I'm interested in #7060 |
|
Is there any news about the release of this feature? Thank you |
|
This would really help with my Usecase, otherwise I can't use inheritance :-( |
|
Any chance for it? Needed for #7060 |
|
Is there any news about this PR? |
|
About the inheritance problem without using the discriminator, I found this workaround: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
[+] Read the contribution guidelines.
[+] Ran the shell script under
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.[+] Filed the PR against the correct branch:
3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.[+] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger
cc: @wing328
Description of the PR
Add mechanism to support inheritance w/o discriminator.
Vendor extension property x-root-ancestor: [true|false] should be used to annotate the root model of hierarchy:
This PR is related to #7593, and reimplemented according to requirements explained in comments there.