Handle when response is a file URL in AlamofireDecodableRequestBuilder.#8700
Open
RedDragonJ wants to merge 2 commits intoswagger-api:masterfrom
Open
Handle when response is a file URL in AlamofireDecodableRequestBuilder.#8700RedDragonJ wants to merge 2 commits intoswagger-api:masterfrom
RedDragonJ wants to merge 2 commits intoswagger-api:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
@ehyche
This is the equivalent change in the AlamofireDecodableRequestBuilder to the change which was made in the non-decodable request in this PR:
#6469
This updates AlamofireImplementations.mustache to handle when the response is an URL. It also makes changes in the generated sample code for:
default configuration (no promisekit or rxswift)
promisekit
rxswift