[Objective-C] Thread safety fix for Object class#9598
Open
michalcichon wants to merge 5 commits intoswagger-api:masterfrom
Open
[Objective-C] Thread safety fix for Object class#9598michalcichon wants to merge 5 commits intoswagger-api:masterfrom
michalcichon wants to merge 5 commits intoswagger-api:masterfrom
Conversation
Synchronizing on [self class] makes several critical sections across all inheriting classes with one shared NSDictionary object (classNames). I believe it wasn't the intention of the author of this fix (based on a JSONModel issue ticket). To make one critical section we need one static object (lock).
Author
|
Unfortunately there is no technical committee for Objective-C. 😞 |
Contributor
|
@michalcichon - do you want to be in one? :) |
Author
|
Hey @webron! I haven't got 3 PRs merged, so I'm afraid I'm not eligible. 😉 My concern was about who's gonna review my pull request. But if you like you can add me as an "interim" member of the technical committee just in case if someone has the same problem as I have. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronizing on [self class] makes several critical sections across all inheriting classes with one shared NSDictionary object (classNames). I believe it wasn't the intention of the author of this fix (based on a JSONModel issue ticket). To make one critical section we need one static object (lock).
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Copied the technical committee to review the pull request if your PR is targeting a particular programming language.Description of the PR
Synchronizing on [self class] makes several critical sections across all inheriting classes with one shared NSDictionary object (classNames). I believe it wasn't the intention of the author of this fix (based on a JSONModel issue ticket). To make one critical section we need one static object (lock).