Skip to content

v1 PR with comment change, shows CI failing for v1 branch#1415

Closed
spacether wants to merge 2 commits intoswagger-api:v1from
spacether:v1
Closed

v1 PR with comment change, shows CI failing for v1 branch#1415
spacether wants to merge 2 commits intoswagger-api:v1from
spacether:v1

Conversation

@spacether
Copy link
Contributor

@spacether spacether commented Aug 4, 2020

v1 PR with comment change, shows CI failing for v1 branch

@spacether spacether changed the title [Test-PR] ignore this v1 PR with comment change, shows CI failing for v1 branch Aug 4, 2020
@spacether
Copy link
Contributor Author

spacether commented Aug 4, 2020

Tests were fixed by mocking out the calls to get the petstore spec from http://petstore.swagger.io/v2/swagger.json
Closing this PR because the commit that fixes those tests has been pulled into #1414

The calls to the url resource were returning:

<html>
<head><title>302 Found</title></head>
<body bgcolor="white">
<center><h1>302 Found</h1></center>
</body>
</html>

Which shows that the code is not following the redirection Location header.

@spacether spacether closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant