fix(spec): update OAS to 3.0.4 and fix core rules #168
Conversation
frantuma
force-pushed
the
petstore-revamp-3.0
branch
from
cdf24e9 to
c1f0f81
Compare
src/main/resources/openapi.yaml
Outdated
| version: 1.0.20-SNAPSHOT | ||
| title: Swagger Petstore - OpenAPI 3.0 | ||
| termsOfService: 'http://swagger.io/terms/' | ||
| termsOfService: http://swagger.io/terms/ |
There was a problem hiding this comment.
There was a problem hiding this comment.
This is just for example purposes. It redirects to https://smartbear.com/terms-of-use/
char0n
left a comment
char0n
left a comment
There was a problem hiding this comment.
Note to general consistency of summary and description fields: some starts with lower case, some with upper case, some ends with . and some don't.
Can I suggest to start both summary and description with uppercase and add dot only to description? This would unify the styling consistenci a bit.
frantuma
left a comment
frantuma
left a comment
There was a problem hiding this comment.
Related to addition of:
default:
description: Unexpected error
content:
application/json:
schema:
$ref: "#/components/schemas/Error"
The current code does not respond with an Error json structure in case of errors (it actually responds with plain text but with json content type..). We can proceed with the changes anyway being this a demo site, and fix the code in scope of different ticket, otherwise we would need to include the changes in this PR
frantuma
force-pushed
the
petstore-revamp-3.0
branch
from
c25d7d8 to
2d041ef
Compare
3 participants
addressing some core rule violations in the OAS description