Dont access button variables directly#5
Open
zaped212 wants to merge 1 commit intosweddavid178:mainfrom
Open
Conversation
Creates new functions Btn*Held to be used instead of accessing the variable directly. This should help reduce confusion seen by the students trying to determine the difference between: joystick.BtnXPressed() vs joystick.BtnX Existing Btns have been converted to private to the class.
Author
|
I haven't had a chance to test this out on a rover yet, but did a find replace and believe I covered all existing usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates new functions Btn*Held to be used instead of accessing the variable directly.
This should help reduce confusion seen by the students trying to determine the difference between:
joystick.BtnXPressed()
vs
joystick.BtnX
Existing Btns have been converted to private to the class.