Skip to content

Conversation

@jakepetroules
Copy link
Contributor

Now disabled jobs will just disappear entirely, rather than appear with confusing unexpanded placeholders.

Now disabled jobs will just disappear entirely, rather than appear with confusing unexpanded placeholders.
@jakepetroules jakepetroules marked this pull request as ready for review November 10, 2025 22:39
@jakepetroules jakepetroules requested a review from a team as a code owner November 10, 2025 22:39
@shahmishal shahmishal merged commit dcbe514 into swiftlang:main Nov 10, 2025
72 of 73 checks passed
@jakepetroules jakepetroules deleted the eng/PR-placeholders branch November 10, 2025 22:43
@ahoppen
Copy link
Member

ahoppen commented Nov 11, 2025

While this nicely cleans up the status checks on the PR (which I love), the workflows are now failing with Matrix vector '...' does not contain any values, for example in https://github.com/swiftlang/swift-syntax/actions/runs/19259914267, which causes a PR run failed email to be sent to the PR author.

@FranzBusch
Copy link
Member

I wasn't in time to comment on this PR but we have been down this path in the swift-nio workflows and this approach is not sufficient enough as indicated by @ahoppen failure. We have tried many things in swift-nio to work around this and the only solution so far was to split the matrix generation and running the matrix into two distinct jobs. I think it would still be the best to see if we can port the approach that NIO came up with to this repo in the near term. Until then I would recommend to revert this change.

shahmishal added a commit that referenced this pull request Nov 11, 2025
shahmishal added a commit that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants