Skip to content

Conversation

@haoNoQ
Copy link

@haoNoQ haoNoQ commented Feb 10, 2021

Clang Static Analyzer is traditionally kept reasonably fresh on stable branches through continuous cherry-picking.

This PR also includes a hotfix for a recently introduced analysis-based warning, -Wcompletion-handler.

SavchenkoValeriy and others added 3 commits February 9, 2021 23:52
It is very common to check callbacks and completion handlers for null.
This patch supports such checks using built-in functions:
  * __builtin_expect
  * __builtin_expect_with_probablity
  * __builtin_unpredictable

rdar://73455388

Differential Revision: https://reviews.llvm.org/D96268

(cherry picked from commit d1522d3)
This reverts commit 3500cc8.

This old commit was made over a completely false premise. OSSymbols
aren't different from other OSObjects and we shouldn't treat them
differently for the purposes of static analysis.

(cherry picked from commit ddb0101)
@haoNoQ
Copy link
Author

haoNoQ commented Feb 10, 2021

@swift-ci test

Copy link

@SavchenkoValeriy SavchenkoValeriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging it!

@haoNoQ haoNoQ merged commit a2b788f into swiftlang:apple/stable/20210107 Feb 10, 2021
@haoNoQ haoNoQ deleted the static-analyzer-cherrypicks-18 branch February 10, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants