🍒[SimplifyCFG] performBranchToCommonDestFolding(): require block-close… #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d SSA form for bonus instructions (PR51125) I can't seem to wrap my head around the proper fix here, we should be fine without this requirement, iff we can form this form, but the naive attempt (https://reviews.llvm.org/D106317) has failed. So just to unblock the release, put up a restriction. Fixes https://bugs.llvm.org/show_bug.cgi?id=51125
Member
Author
|
swiftlang/swift-corelibs-foundation#3091 @swift-ci please test |
Member
Author
|
@swift-ci please test windows Platform |
This was referenced Oct 16, 2021
compnerd
approved these changes
Oct 16, 2021
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
(only in the sense that this looks like the right cherry-pick, is a proper cherry-pick of the upstream change and does resolve the actual issue. I've not spent the time to fully digest and carefully the actual upstream change).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d SSA form for bonus instructions (PR51125)
This appears to be the cause of SR-15302.
The fix for the bad optimization was integrated into LLVM shortly after the 2021-07-26 branch was cut.
The fixing commit was: llvm@909cba9
Original commit message:
I can't seem to wrap my head around the proper fix here,
we should be fine without this requirement, iff we can form this form,
but the naive attempt (https://reviews.llvm.org/D106317) has failed.
So just to unblock the release, put up a restriction.
Fixes https://bugs.llvm.org/show_bug.cgi?id=51125