Skip to content

Conversation

@compnerd
Copy link
Member

Reverts #3662

This is likely the culprit of the Windows build regression: https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/495/console

CC: @JDevlieghere @etcwilde

@compnerd
Copy link
Member Author

@swift-ci please test

@JDevlieghere
Copy link

The error says it can't find '/GenerateVersionFromVCS.cmake', which implies that ${LLVM_CMAKE_DIR} is empty in "${LLVM_CMAKE_DIR}/GenerateVersionFromVCS.cmake". Why would this only happen on Windows?

@compnerd
Copy link
Member Author

Likely not a Windows specific thing but rather a unified build thing.

@JDevlieghere
Copy link

Ah, that would make more sense. That's something I can reproduce more easily.

@JDevlieghere
Copy link

I reproduced the issue locally and confirmed that #3692 fixes it.

@compnerd compnerd deleted the revert-3662-🍒/FBI/ccf1469a4cdb+eaf4f60507fd branch December 15, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants