Skip to content

Revert "[dsymutil] Emit an error when the Mach-O exceeds the 4GB limit." #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDevlieghere merged 1 commit into from
Mar 24, 2022
Merged

Revert "[dsymutil] Emit an error when the Mach-O exceeds the 4GB limit." #4113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions llvm/tools/dsymutil/dsymutil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,19 +689,6 @@ int main(int argc, char **argv) {
Options.LinkOpts, SDKPath))
return EXIT_FAILURE;
}

// The Mach-O object file format is limited to 4GB. Make sure that we print
// an error when we emit an invalid Mach-O companion file. Leave the
// invalid object file around on disk for inspection.
ErrorOr<vfs::Status> stat =
Options.LinkOpts.VFS->status(OutputLocationOrErr->DWARFFile);
if (stat) {
if (stat->getSize() > std::numeric_limits<uint32_t>::max()) {
WithColor::error() << "the linked debug info exceeds the 4GB Mach-O "
"object file format.";
return EXIT_FAILURE;
}
}
}

return EXIT_SUCCESS;
Expand Down