[build-script] Add --parallel to supress output on success#261
Merged
benlangmuir merged 2 commits intoswiftlang:masterfrom Apr 8, 2020
Merged
[build-script] Add --parallel to supress output on success#261benlangmuir merged 2 commits intoswiftlang:masterfrom
benlangmuir merged 2 commits intoswiftlang:masterfrom
Conversation
Contributor
Author
|
@swift-ci please test |
It's slightly faster and it helps supress the test output when tests succeed (which avoids false positives in Jenkins' error regexes, for example the error from "let pack" in a test).
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Linux |
Contributor
Author
|
Looks like testCloseRace hangs in It's polling file descriptors, so probably double close on the FD or something. |
Close the fd via the FileHandle rather than directly on the file descriptor so that it does not get closed again when the pipe is released. Fixes running test in parallel on Linux.
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's slightly faster and it helps supress the test output when tests
succeed (which avoids false positives in Jenkins' error regexes, for
example the error from "let pack" in a test).