Include trailing () in macro URLs. #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krilnon
approved these changes
Jul 24, 2023
Member
krilnon
left a comment
krilnon
left a comment
There was a problem hiding this comment.
Yep, these changes match my expectation what's required for macro URLs going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change matches an upstream change in the publication pipeline that will start including the
()at the end of macro's names. TSPL started linking to the macros that replace what used to be special literals in commit f2828dd, which is on 'main' but isn't yet included in the published content. So if the publication pipeline updates before this PR is merged, that's also ok — the links that would break aren't there yet.Fixes: rdar://112501547