Skip to content

Conversation

@nethraravindran
Copy link
Contributor

@nethraravindran nethraravindran commented Jun 20, 2017

Since ProtocolClient implementation seems to be relevant to URLSession, it makes sense to move it to URLSessionTask.

@pushkarnk
Copy link
Member

Seems reasonable. Can you please consider including the changes of #1049 once that is merged?

@pushkarnk pushkarnk changed the title [NSURLSession] Move URLProtocolClient to URLSessionTask [NSURLSession] Move URLProtocolClient to URLSessionTask.swift Jun 20, 2017
@pushkarnk pushkarnk changed the title [NSURLSession] Move URLProtocolClient to URLSessionTask.swift [NSURLSession] Move the default URLProtocolClient implementation to URLSessionTask.swift Jun 20, 2017
Copy link
Member

@pushkarnk pushkarnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the changes in #1049 are synced up here.

@pushkarnk
Copy link
Member

@swift-ci please test

1 similar comment
@pushkarnk
Copy link
Member

@swift-ci please test

@pushkarnk pushkarnk changed the title [NSURLSession] Move the default URLProtocolClient implementation to URLSessionTask.swift [URLSession] Move the default URLProtocolClient implementation to URLSessionTask.swift Jun 23, 2017
@pushkarnk pushkarnk merged commit 226e078 into swiftlang:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants