Skip to content

URLSession: fix compile warning #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swift-ci merged 1 commit into from
Aug 2, 2017
Merged

URLSession: fix compile warning #1110

swift-ci merged 1 commit into from
Aug 2, 2017

Conversation

@ianpartridge
Copy link
Contributor

@ianpartridge ianpartridge commented Jul 11, 2017

Fixes warning:

'scheduleRepeating(deadline:interval:leeway:)' is deprecated: renamed to 'schedule(deadline:repeating:leeway:)'
Use 'schedule(deadline:repeating:leeway:)' instead

@pushkarnk

@pushkarnk
Copy link
Member

pushkarnk commented Jul 11, 2017

@swift-ci test and merge

@ianpartridge
Copy link
Contributor Author

ianpartridge commented Jul 11, 2017 

Foundation/NSURLSession/http/MultiHandle.swift:331:9: error: value of type 'DispatchSource' has no member 'schedule'
        rawSource.schedule(deadline: start, repeating: .milliseconds(Int(delay)), leeway: (milliseconds == 1) ? .microseconds(Int(1)) : .milliseconds(Int(1)))
        ^~~~~~~~~ ~~~~~~~~

I'll investigate and reopen. Looks like the Dispatch overlay needs fixing first.

@ianpartridge ianpartridge deleted the multihandle-warning branch July 27, 2017 15:24
@ianpartridge ianpartridge restored the multihandle-warning branch August 1, 2017 22:20
@ianpartridge
Copy link
Contributor Author

ianpartridge commented Aug 1, 2017

Reopening now that swiftlang/swift-corelibs-libdispatch#289 is merged, which updates the Dispatch overlay on Linux to match Darwin.

@ianpartridge ianpartridge reopened this Aug 1, 2017
@ianpartridge
Copy link
Contributor Author

ianpartridge commented Aug 2, 2017

@swift-ci please test and merge

@swift-ci swift-ci merged commit e61b4c3 into swiftlang:master Aug 2, 2017
@ianpartridge ianpartridge deleted the multihandle-warning branch August 2, 2017 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianpartridge @pushkarnk @swift-ci