Explicitly import Glibc in files that rely on it #2921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc/ @CodaFi @gribozavr |
Contributor
|
@swift-ci test |
|
CC @hlopko |
|
Friendly ping :) |
compnerd
approved these changes
Nov 18, 2020
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
I'm still not convinced by canImport, but that is the convention in the repository ... and, when in Rome ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files rely on Glibc declarations in their public interface, even though they don’t import Glibc. Currently, these declarations are discovered through CoreFoundation, but due to implementation details, Swift canonicalizes the declarations and at the end uses declarations from Glibc (which is imported by other files in the module). This confuses
@_implementationOnlychecker to recognize these declarations as visible even though they shouldn't be.This is fragile as Foundation now relies on implementation details of Glibc, which in fact we are trying to change in swiftlang/swift#32404.
This PR fixes the issue by explicitly importing Glibc in affected files.