Check for invalid URLRequest header values #4650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swift-ci test |
jrflat
added a commit
to jrflat/swift-corelibs-foundation
that referenced
this pull request
Jan 11, 2023
Co-authored-by: Jonathan Flat <jflat@apple.com>
jrflat
added a commit
to jrflat/swift-corelibs-foundation
that referenced
this pull request
Jan 11, 2023
Co-authored-by: Jonathan Flat <jflat@apple.com>
parkera
pushed a commit
that referenced
this pull request
Jan 12, 2023
parkera
pushed a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URLRequest implementation previously allowed arbitrary CR and LF characters in header values. This change checks header values for invalid characters before setting or adding them to the request. It does allow for header line folding (CRLF followed by HTAB or SP), consistent with URLRequest on Darwin.