Add NSLock.withLock(_:) method
#4736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
approved these changes
Apr 23, 2023
Contributor
|
@swift-ci test |
Contributor
Author
|
Contributor
|
@swift-ci test |
Contributor
Author
|
All three pipelines failed with different errors. 😳 |
Contributor
|
@swift-ci test |
Contributor
Author
|
@parkera Shall we do |
Contributor
Author
|
@parkera Is the automated test infrastructure behaving better these days? |
Contributor
|
@swift-ci test |
Contributor
Author
|
😢 |
Fixes swiftlang#4735. Xcode 14 introduced the `NSLocking.withLock(_:)` method to the Darwin implementation of Foundation. This commit adds the new method to the open-source implementation. (Note: The [documentation](https://developer.apple.com/documentation/foundation/nslocking/4059821-withlock) incorrectly specifies the availability of the method as iOS 16+, etc. but it is actually available on all OS versions because it is marked [`@_alwaysEmitIntoClient`](https://github.com/apple/swift/blob/main/docs/ReferenceGuides/UnderscoredAttributes.md#_alwaysemitintoclient). The documentation bug is tracked by [FB11968310](https://feedbackassistant.apple.com/feedback/11968310).) I copied the implementation from `Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/Foundation.framework/Modules/Foundation.swiftmodule/arm64e-apple-ios.swiftinterface`.
Contributor
|
@swift-ci test |
Contributor
Author
|
I hope there’s someone working full-time on making the automated test infrastructure more reliable. 😕 |
Contributor
Author
|
The macOS issue seems to be The Windows issue is |
Contributor
Author
|
😢 |
Contributor
|
@swift-ci test |
Contributor
Author
|
All checks passed! |
Contributor
Author
|
Happy New Year! Merge, please. 😭 |
parkera
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4735.
Xcode 14 introduced the
NSLocking.withLock(_:)method to the Darwin implementation of Foundation. This commit adds the new method to the open-source implementation.(Note: The documentation incorrectly specifies the availability of the method as iOS 16+, etc. but it is actually available on all OS versions because it is marked
@_alwaysEmitIntoClient. The documentation bug is tracked by FB11968310.)I copied the implementation from
Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/Foundation.framework/Modules/Foundation.swiftmodule/arm64e-apple-ios.swiftinterface.