CG types are sendable #4874
Merged
CG types are sendable #4874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Feb 15, 2024
Member
|
@swift-ci please test |
jumhyn-browser
force-pushed
the
cg-types-sendable
branch
from
ca2565e to
d5c78dc
Compare
Member
|
@swift-ci please test |
Member
|
@swift-ci please test Windows platform |
Contributor
Author
|
Windows run succeeded but didn't get linked back here for some reason |
Member
|
@swift-ci please test Windows platform |
jmschonfeld
approved these changes
Feb 19, 2024
Contributor
jmschonfeld
left a comment
jmschonfeld
left a comment
There was a problem hiding this comment.
All looks fine to me, they're all trivial structs so they can definitely be Sendable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think these should all be fine?