Re-core Foundation on top of swift-foundation (merge package branch into main) #5008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the toolchain, by renaming the module
) From Clang 15, nested static initializer inside statement-expression is no longer a constant-time expression (See https://reviews.llvm.org/D127201). OSS Foundation defines `CFSTR` as a macro rather than `__builtin___CFStringMakeConstantString` and it uses nested static initializer inside statement-expression, so we can't assume `CFSTR` itself is always a constant-time expression. This patch removes some `static` qualifiers associated with `CFSTR` to make them acceptable with Clang 15 and later.
Merge the main branch into package
Introduce Cmake support for SwiftCorelibsFoundation
* Add -Wno-int-conversion and -fPIC * Move block runtime sources into separate ignored folder * Install private static libs in static swift build * Don't include stdlib toolchain rpath * Autolink static libraries in static swift build * Bump WINVER/_WIN32_WINNT to Windows 10 * Repair package manifest
* Add plutil to CMake build * Address review comments
We should use build IDs on Linux so that we can identify the built artefacts, and also so that we can match them up with debug information should we choose to separate it. rdar://130582768
* Various fixes to allow for building on Windows * Enable shared libraries by default * Resolve Windows compiler flag warnings and fix constant string symbols
* Use FSR for Process executable path on Windows * Use FSR on Linux as well
Fix the include path to Dispatch in Package.swift
Contributor
Author
parkera
approved these changes
Jul 15, 2024
Contributor
Author
|
swiftlang/swift-installer-scripts#312 @swift-ci please test Linux platform |
Contributor
Author
|
The macOS failure is known - this repo no longer builds for macOS and macOS testing is no longer required. Linux and Windows test have now passed which means we're clear to merge the re-core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change merges the
packagebranch (tracking all of our work to re-core Foundation on top of swift-foundation that many folks have been working on) into themainbranch. At this point, all tests pass on Linux and Windows and we're able to produce functional Linux and Windows toolchains in swift-ci. This change may be too large to review itself, but this work has been reviewed in pieces over the course of a number of months via PRs to thepackagebranch.Resolves #5001