queue_specific_queue is missing its do_push vtable entry #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reorder all vtable entries to be in the same order (push, invoke, wakeup). Reenable dispatch_context_for_key. SR: SR-4039
Contributor
Author
|
@swift-ci please test |
das
reviewed
Feb 23, 2017
| .do_dispose = _dispatch_queue_dispose, | ||
| .do_invoke = _dispatch_queue_invoke, | ||
| .do_push = _dispatch_queue_push, | ||
| .do_invoke = _dispatch_queue_invoke, |
Contributor
There was a problem hiding this comment.
FWIW push -> wakeup -> invoke would have seemed the natural order to me ;-)
Contributor
Author
There was a problem hiding this comment.
I just kept the order that was dominating. For real the better order is:
wakeup -> push -> invoke. (cause it's in that order it happens)
Contributor
Author
There was a problem hiding this comment.
actually no I'm tired, it's push on self, wakeup onto target, then invoke you're correct :P
das
approved these changes
Feb 23, 2017
dgrove-oss
reviewed
Feb 23, 2017
Contributor
dgrove-oss
left a comment
dgrove-oss
left a comment
There was a problem hiding this comment.
Looks good to me; I applied the fix of adding the missing .do_push entry to the queue_specific_queue vtable and have been run dispatch_context_for_key in loop without crashing for several thousand iterations. Was crashing in < 100 iterations before.
das
added a commit
that referenced
this pull request
May 25, 2017
queue_specific_queue is missing its do_push vtable entry Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reorder all vtable entries to be in the same order (push, invoke,
wakeup).
Reenable dispatch_context_for_key.
SR: SR-4039