libdispatch: Avoid submodules for headers that should not be included #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libdispatch has an umbrella header, dispatch.h, that should be used for including all of the other headers. This is enforced via __DISPATCH_INDIRECT__. Since it isn't legal to include one of the other headers on their own, it isn't logical to have submodules for them. Moreover, submodules *should* have local visibility (be unaware of the context they're included from); meaning that __DISPATCH_INDIRECT__ will never be defined. Logically, all of the headers are part of a single module/interface. Patch by me & Duncan P. Exon Smith
Contributor
Author
|
@swift-ci please test |
das
added a commit
that referenced
this pull request
May 25, 2017
libdispatch: Avoid submodules for headers that should not be included Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libdispatch has an umbrella header, dispatch.h, that should be used for
including all of the other headers. This is enforced via
DISPATCH_INDIRECT.
Since it isn't legal to include one of the other headers on their own,
it isn't logical to have submodules for them. Moreover, submodules
should have local visibility (be unaware of the context they're
included from); meaning that DISPATCH_INDIRECT will never be
defined.
Logically, all of the headers are part of a single module/interface.
Patch by me & Duncan P. Exon Smith