Windows cleanups #245
Merged
Windows cleanups #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys/cdefs.h and unistd.h are not always available. We already have checks for these, guard the inclusion appropriately.
Rather than checking for non-Linux and including the target specific header, invert the check and include the linux target header if `__linux__` is defined. This makes it easier to target other platforms.
Address some of the portability considerations for the build flags. This improves some of the conditions for building for Windows.
Contributor
|
I thought that MSVC was supporting clang nowadays? I don't think we will ever be able to use MSVC as a compiler for the larger goal of supporting Swift because you will need blocks support and many other things. am I missing something here? |
Member
Author
|
Yeah, if you look at the diffs, the assumption is that you are using clang. The support here is for the clang cl driver. |
Contributor
|
oh I didn't realize that MSVC had a driver exposed through the same weird Windows command line parsing. I guess it makes sense, the same way clang is compatible with gcc CLI ;) ok let me look at it again with that in mind then! |
MadCoder
approved these changes
May 7, 2017
Contributor
|
@swift-ci please test |
Contributor
|
it is invalid to put HAVE_* type checks in to API and SPI headers, there is no config.h file included by API clients on Darwin |
das
pushed a commit
that referenced
this pull request
May 25, 2017
Windows cleanups Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some cl flags handling to the build system. Improve macros for Windows builds to detect the target correctly. This is not enough to perform a full Windows build yet but addresses some of the low hanging fruit.