Skip to content

Conversation

@compnerd
Copy link
Member

Add the missing support for dtrace header script support.

@compnerd
Copy link
Member Author

@dgrove-oss does this work for you? (I dont have dtrace installed, so if you could test this, it would be wonderful)

@dgrove-oss
Copy link
Contributor

dgrove-oss commented Jun 28, 2017

Almost, you need to add the directory in which provider.h is generated to the includes. With the additional patch below it works for me.

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index ca6ef75..bdc9162 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -115,6 +115,7 @@ endif()
 target_include_directories(dispatch
                            PRIVATE
                              ${CMAKE_BINARY_DIR}
+                             ${CMAKE_CURRENT_BINARY_DIR}
                              ${CMAKE_SOURCE_DIR}
                              ${CMAKE_CURRENT_SOURCE_DIR}
                              ${CMAKE_SOURCE_DIR}/private)

Add the missing support for dtrace header script support.
@compnerd compnerd force-pushed the dtrace-usdt-probes branch from aae478c to 86fa1f9 Compare June 29, 2017 01:24
@compnerd
Copy link
Member Author

@dgrove-oss updated

@das
Copy link
Contributor

das commented Jun 29, 2017

awesome, thanks!

@das das merged commit ab89c6c into swiftlang:master Jun 29, 2017
das added a commit that referenced this pull request Jul 31, 2017
build: add dtrace USDT probe support

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
@das das removed the darwin pending label Aug 1, 2017
@compnerd compnerd deleted the dtrace-usdt-probes branch February 15, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants