Remove dependency on sys_membarrier on linux #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is the right way of doing #228 |
MadCoder
force-pushed
the
mad/remove-sys-membarrier
branch
2 times, most recently
from
f9424ee to
12fc950
Compare
Contributor
Author
|
@swift-ci please test |
das
requested changes
Jul 14, 2017
|
|
||
| DISPATCH_ONCE_SLOW_INLINING | ||
| static void | ||
| dispatch_once_f_slow(dispatch_once_t *val, void *ctxt, dispatch_function_t func) |
src/once.c
Outdated
| void | ||
| dispatch_once_f(dispatch_once_t *val, void *ctxt, dispatch_function_t func) | ||
| #if DISPATCH_ONCE_INLINE_FASTPATH | ||
| #define DISPATCH_ONCE_SLOW_INLINING inline DISPATCH_ALWAYS_INLINE |
Contributor
There was a problem hiding this comment.
INLINING seems weird, DISPATCH_ONCE_SLOW_INLINE ?
By not inlining the fastpath of dispatch_once() when the hardware cannot give us the right semantics.
MadCoder
force-pushed
the
mad/remove-sys-membarrier
branch
from
12fc950 to
93d2dd9
Compare
Contributor
Author
|
@das handled |
Contributor
Author
|
Adding @dgrove-oss which I should have done from the get go |
das
approved these changes
Jul 14, 2017
This was referenced Jul 15, 2017
das
added a commit
that referenced
this pull request
Jul 31, 2017
Remove dependency on sys_membarrier on linux Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not inlining the fastpath of dispatch_once() when the hardware cannot
give us the right semantics.