Ignore Windows FLS destructors during process exit #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There's a quirk on Windows where exiting the process will still run fiber-local storage destructors for the thread that called ExitProcess() (but only for that thread). pthreads-based platforms don't call any key destructors on exit, and _libdispatch_tsd_cleanup() assumes this. So, on Windows, calling exit() from a queue thread will trigger the fatal error in _dispatch_frame_cleanup(). Implement a reliable method of detecting whether the process is exiting, and if it is, ignore calls to _libdispatch_tsd_cleanup().
compnerd
approved these changes
Jun 27, 2018
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This is quite a clever approach. Thanks for adding the comments explaining what is going on.
Member
|
@swift-ci please test |
MadCoder
approved these changes
Jun 29, 2018
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
Ignore Windows FLS destructors during process exit Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a quirk on Windows where exiting the process will still run fiber-local
storage destructors for the thread that called ExitProcess() (but only for that
thread). pthreads-based platforms don't call any key destructors on exit, and
_libdispatch_tsd_cleanup() assumes this. So, on Windows, calling exit() from a
queue thread will trigger the fatal error in _dispatch_frame_cleanup().
Implement a reliable method of detecting whether the process is exiting, and if
it is, ignore calls to _libdispatch_tsd_cleanup().