Remove generic_unix_stubs #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generic_unix_stubs.c seems to no longer be necessary. generic_unix_stubs.h still had some required definitions in it, so move those into shims.h and a new shims/mach.h. This also lets us remove some duplicated definitions in the Windows shims.
Contributor
Author
Member
|
Seems reasonable |
compnerd
approved these changes
Jul 17, 2018
Member
|
@swift-ci test |
ktopley-apple
approved these changes
Aug 20, 2018
ktopley-apple
added a commit
that referenced
this pull request
Dec 6, 2018
Remove generic_unix_stubs Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generic_unix_stubs.c seems to no longer be necessary. generic_unix_stubs.h still
had some required definitions in it, so move those into shims.h and a new
shims/mach.h. This also lets us remove some duplicated definitions in the
Windows shims.