Skip to content

Conversation

@dingobye
Copy link
Contributor

This patch aims to make swift-corelibs-libdispatch adapted to this PR, which warns for version number in 'available' attribute for non-specific platform '*'.

@jrose-apple
Copy link
Contributor

Do we care about watchOS and tvOS too? tvOS version numbers match iOS's, but watchOS's don't.

@ktopley-apple
Copy link
Contributor

I agree with Jordan - the tvOS and watchOS deprecations should also be included.

@jrose-apple
Copy link
Contributor

I don't think I or Ding knows for sure what those should be! It's also a little funny that these are just in corelibs-dispatch, which is never used on iOS/tvOS/watchOS. Or did we miss some in the overlays too?

@dingobye
Copy link
Contributor Author

dingobye commented Aug 24, 2018

Thank you for the feedbacks, Jordan and Kim!

Can we just remove those lines of @available(*, deprecated: 8.0, ...) here? Just take a look at the relevant part in swift main repo. There are attributes for four platforms macOS/iOS/tvOS/watchOS, among which I think keeping only macOS is sufficient for swift-corelibs-libdispatch project.

@jrose-apple
Copy link
Contributor

I suspect that SCD is trying to match the contents of the Darwin overlay exactly for most of these files, and that they should therefore be kept in sync.

@dingobye
Copy link
Contributor Author

Alright, let's keep it in sync. This is a conservative solution anyway.

@jrose-apple
Copy link
Contributor

@swift-ci Please test Linux

Copy link
Contributor

@ktopley-apple ktopley-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me as it is. I think we need to review whether any of these @available lines are required as a separate exercise.

@ktopley-apple ktopley-apple merged commit 81dc900 into swiftlang:master Aug 30, 2018
ktopley-apple added a commit that referenced this pull request Dec 6, 2018
Remove version number used in 'available' attribute for non-specific platform '*'.

Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants