build: make the static build work well #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to make the shared+static build for build-script work. The primary issue is the dependency on the module-maps doesn't work due to the lack of add_custom_command, so the target dependency cannot be hooked up. Additionally, undo the hack for the AST_NAME as we need that to be proper for the copy to succeed. Finally, make sure that the we set the location for the archive output correctly.
Member
Author
|
@swift-ci please test |
Member
Author
ktopley-apple
approved these changes
Nov 27, 2018
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
build: make the static build work well Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to make the shared+static build for build-script work. The
primary issue is the dependency on the module-maps doesn't work due to the lack
of add_custom_command, so the target dependency cannot be hooked up.
Additionally, undo the hack for the AST_NAME as we need that to be proper for
the copy to succeed. Finally, make sure that the we set the location for the
archive output correctly.