-
Notifications
You must be signed in to change notification settings - Fork 216
[Explicit Module Builds] Centralize computing *all* dependencies of a given ModuleInfo and use throughout
#1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
artemcm
merged 1 commit into
swiftlang:main
from
artemcm:AlwaysAllDependenciesAllTheTime
Apr 14, 2025
Merged
[Explicit Module Builds] Centralize computing *all* dependencies of a given ModuleInfo and use throughout
#1869
artemcm
merged 1 commit into
swiftlang:main
from
artemcm:AlwaysAllDependenciesAllTheTime
Apr 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
15f93bc to
f04f086
Compare
Contributor
Author
|
@swift-ci test |
f04f086 to
d4e2d4c
Compare
Contributor
Author
|
@swift-ci test |
d4e2d4c to
aa564ae
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
… given 'ModuleInfo' and use throughout This is in preparation of dependency scanner turning the 'directDependencies' field to contain only actually-directly-imported modules.
aa564ae to
c114130
Compare
Contributor
Author
|
@swift-ci test Windows platform |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
cachemeifyoucan
approved these changes
Apr 14, 2025
Contributor
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of dependency scanner turning the
directDependenciesfield to contain only actually-directly-imported modules.