Bump required CMake version to 3.17 #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several key livability fixes in 3.17 for building Swift code. This should prevent scenarios like this: swiftlang/swift#37114 Where CMake `<3.17` missed setting up rpaths on the `swift-driver` executable.
Contributor
Author
|
@swift-ci please test |
This was referenced Apr 30, 2021
shahmishal
approved these changes
May 1, 2021
Contributor
|
I am going to merge this since Mishal approved and I don't think it will hurt anything from my conversation with Artem. I want to do some work to build on top of Artem's work on early swift driver. Doing that is blocked on this PR landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several key livability fixes in 3.17 for building Swift code.
This should prevent scenarios like this:
swiftlang/swift#37114
Where CMake
<3.17missed setting up rpaths on theswift-driverexecutable.