Pass the canonical SDK name to the frontend for swiftmodule checking #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Could you please (1) update |
Contributor
Author
|
@nkcsgexi How can we check if a flag is supported by the compiler? |
Contributor
Author
|
Nevermind, there's a |
Contributor
|
Right, it's especially necessary when we are using one single driver instance to orchestrate multiple compilers. |
xymus
force-pushed
the
pass-sdk-name
branch
from
196c26a to
a19861b
Compare
Contributor
Author
|
Adding commits for the suggested changes. @swift-ci Please test |
nkcsgexi
approved these changes
Sep 14, 2021
Contributor
|
+1 nice addition |
Contributor
Author
|
@swift-ci Please test |
The frontend will use this information to control which swiftmodule file can be loaded according to the SDK in use. Swiftmodule files should only be used in the context of the SDK used to create them. This will catch issues with roots and other configuration problems. rdar://83104265
Contributor
Author
|
Other SDK sanity checks have landed. I believe it's time to merge this one. @swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the canonical SDK name to the frontend for it to control which swiftmodule file can be loaded according to the SDK in use. Swiftmodule files should only be used in the context of the SDK used to create them. This will catch issues with roots and other similar configuration problems.
rdar://83104265
Related compiler-side PR: swiftlang/swift#37768