Formatting not working on Windows

[tomwyr]

The formatting does not seem to work properly when compiled on Windows. The compilation went smoothly, however, when used as CLI as well as together with vscode formatter, the behavior is incorrect:

• Running swift-format command from bash/powershell hangs without any output and never completes.
• Running Format document With with apple-swift-format empties content of the editor the formatting is run on.

Tested on

• Windows 11 (10.0.22631 Build 22631)
• Swift 5.9.2
• swift-format 509.0.0
• apple-swift-format 1.4.3

[ahoppen]

Tracked in Apple’s issue tracker as rdar://126948386

[kkebo]

This infinite loop occurred not only on Windows, but also on other platforms.

For example, on Linux, candidateDirectory.path changed as follows.

• /foo/bar/baz
• /foo/bar
• /foo
• (empty string)
• (empty string)
• (empty string)
• ...

So it couldn't match / forever.

Fortunately, #802 seems to fix the issue on Linux as well. I hope that this fix will ship as soon as possible.

By the way, I think the following behavior is the root cause.

$ swift repl 
Welcome to Swift version 6.0.2-dev (LLVM 43d73cb0cc589f7, Swift aaa632cea622394).
Type :help for assistance.
  1> import Foundation
  2> URL(filePath: "/foo", directoryHint: .notDirectory).deletingLastPathComponent().path
$R0: String = "/"
  3> URL(filePath: "/foo", directoryHint: .isDirectory).deletingLastPathComponent().path 
$R1: String = ""

[omochi]

That’s due to this bug.
swiftlang/swift-foundation#922