Skip to content

Make Rule nameCache thread safe #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allevato merged 1 commit into from
Nov 13, 2020
Merged

Make Rule nameCache thread safe #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Sources/SwiftFormatCore/Rule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
//
//===----------------------------------------------------------------------===//

import Foundation

/// A Rule is a linting or formatting pass that executes in a given context.
public protocol Rule {
/// The context in which the rule is executed.
Expand All @@ -26,16 +28,26 @@ public protocol Rule {
}

fileprivate var nameCache = [ObjectIdentifier: String]()
fileprivate var nameCacheQueue = DispatchQueue(
label: "com.apple.SwiftFormat.NameCache", attributes: .concurrent)

extension Rule {
/// By default, the `ruleName` is just the name of the implementing rule class.
public static var ruleName: String {
let identifier = ObjectIdentifier(self)
if let cachedName = nameCache[identifier] {
let cachedName = nameCacheQueue.sync {
nameCache[identifier]
}

if let cachedName = cachedName {
return cachedName
}

let name = String("\(self)".split(separator: ".").last!)
nameCache[identifier] = name
nameCacheQueue.async(flags: .barrier) {
nameCache[identifier] = name
}

return name
}
}