Skip to content

Fix parallel mode on larger projects #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keith wants to merge 1 commit into from
Closed

Fix parallel mode on larger projects #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/swift-format/Frontend/Frontend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,11 @@ class Frontend {
"processURLs(_:) should only be called when 'urls' is non-empty.")

if parallel {
let filesToProcess = FileIterator(urls: urls).compactMap(openAndPrepareFile)
let filesToProcess = Array(FileIterator(urls: urls))
DispatchQueue.concurrentPerform(iterations: filesToProcess.count) { index in
processFile(filesToProcess[index])
if let file = openAndPrepareFile(at: filesToProcess[index]) {
processFile(file)
}
}
} else {
FileIterator(urls: urls).lazy.compactMap(openAndPrepareFile).forEach(processFile)
Expand Down