WiX: adjust manifest for thick module for Dispatch #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the manifest rules to account for the fact that libdispatch now properly stages the swiftmodule in a thick module format. This avoids us having to shuffle files around when building the installer.
Member
Author
|
Associated with swiftlang/swift-corelibs-libdispatch#860. |
Member
Author
|
Closing this as we now expect the thick module and perform the shuffling outside of the manifest. As the pieces for the libdispatch build land, we should be able to remove that shuffling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the manifest rules to account for the fact that libdispatch now properly stages the swiftmodule in a thick module format. This avoids us having to shuffle files around when building the installer.